Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Thu, 30 Nov 2017 16:57:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13121733.1511989770000.356648.1512061020754@Atlassian.JIRA>
In-Reply-To: <JIRA.13121733.1511989770000@Atlassian.JIRA>
References: <JIRA.13121733.1511989770000@Atlassian.JIRA> <JIRA.13121733.1511989770334@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-4029) Deployed jars may not be correct
 when multiple locators are in use
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Thu, 30 Nov 2017 16:57:06 -0000


    [ https://issues.apache.org/jira/browse/GEODE-4029?page=3Dcom.atlassian=
.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1627=
2937#comment-16272937 ]=20

ASF GitHub Bot commented on GEODE-4029:
---------------------------------------

jinmeiliao commented on a change in pull request #1103: GEODE-4029: Deploye=
d jars may not be correct when multiple locators a=E2=80=A6
URL: https://github.com/apache/geode/pull/1103#discussion_r153929260
=20
=20

 ##########
 File path: geode-core/src/main/java/org/apache/geode/distributed/internal/=
ClusterConfigurationService.java
 ##########
 @@ -352,6 +358,20 @@ public boolean removeJars(final String[] jarNames, St=
ring[] groups) {
         if (configuration =3D=3D null) {
           break;
         }
+
+        for (String jarRemoved : jarNames) {
=20
 Review comment:
   we don't need to do this if we remove the isOriginRemote() check in the =
listener. Essentially we want all the updates to touch just the region entr=
y, while letting the listener deal with the file system update.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
=20
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Deployed jars may not be correct when multiple locators are in use
> ------------------------------------------------------------------
>
>                 Key: GEODE-4029
>                 URL: https://issues.apache.org/jira/browse/GEODE-4029
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>            Reporter: Jens Deppe
>            Assignee: Jens Deppe
>
> When we have more than one locator, if a jar is re-deployed it will not b=
e propagated correctly to the 'remote' locators. i.e. the locators which ar=
e not directly executing the 'deploy' command.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)