Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Wed, 29 Nov 2017 23:42:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13116068.1509745180000.350589.1511998920364@Atlassian.JIRA>
In-Reply-To: <JIRA.13116068.1509745180000@Atlassian.JIRA>
References: <JIRA.13116068.1509745180000@Atlassian.JIRA> <JIRA.13116068.1509745180051@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-3955) The gfsh 'describe region' command
 doesn't include asyncEventQueueIds or gatewaySenderIds
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 29 Nov 2017 23:42:06 -0000


    [ https://issues.apache.org/jira/browse/GEODE-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271806#comment-16271806 ] 

ASF GitHub Bot commented on GEODE-3955:
---------------------------------------

PurelyApplied commented on a change in pull request #1099: GEODE-3955: Add AEQ and Gateway Sender information to 'describe region' output.
URL: https://github.com/apache/geode/pull/1099#discussion_r153948504
 
 
 ##########
 File path: geode-wan/src/test/java/org/apache/geode/management/internal/cli/commands/DescribeRegionDUnitTest.java
 ##########
 @@ -0,0 +1,165 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
+ * or implied. See the License for the specific language governing permissions and limitations under
+ * the License.
+ */
+package org.apache.geode.management.internal.cli.commands;
+
+import static org.apache.geode.distributed.ConfigurationProperties.DISTRIBUTED_SYSTEM_ID;
+import static org.apache.geode.distributed.ConfigurationProperties.REMOTE_LOCATORS;
+
+import java.util.Properties;
+
+import org.junit.BeforeClass;
+import org.junit.ClassRule;
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.CacheFactory;
+import org.apache.geode.cache.EvictionAction;
+import org.apache.geode.cache.EvictionAttributes;
+import org.apache.geode.cache.FixedPartitionAttributes;
+import org.apache.geode.cache.PartitionAttributes;
+import org.apache.geode.cache.PartitionAttributesFactory;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionFactory;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.test.dunit.rules.LocatorServerStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.junit.categories.DistributedTest;
+import org.apache.geode.test.junit.rules.GfshCommandRule;
+
+@Category(DistributedTest.class)
 
 Review comment:
   I could be wrong, but I had thought that line was drawn between `DUnit` tests using `LocatorServerStartupRule` and `AcceptanceTest`s using `GfshRule`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> The gfsh 'describe region' command doesn't include asyncEventQueueIds or gatewaySenderIds
> -----------------------------------------------------------------------------------------
>
>                 Key: GEODE-3955
>                 URL: https://issues.apache.org/jira/browse/GEODE-3955
>             Project: Geode
>          Issue Type: Improvement
>          Components: management
>            Reporter: Barry Oglesby
>            Priority: Minor
>             Fix For: 1.4.0
>
>         Attachments: geode-3955.diff
>
>
> The {{constructor}} and {{getNonDefaultAttributes}} methods in {{org.apache.geode.management.internal.cli.domain.RegionAttributesInfo}} class would have to be modified to include the {{asyncEventQueueIds}} and {{gatewaySenderIds}}. 
> I did a quick modification of this class (attached).
> With these changes, 'describe region' looks like:
> {noformat}
> gfsh>describe region --name=/data
> ..........................................................
> Name            : data
> Data Policy     : partition
> Hosting Members : ln-1
> Non-Default Attributes Shared By Hosting Members  
>   Type    |         Name          | Value
> --------- | --------------------- | ---------
> Region    | data-policy           | PARTITION
>           | async-event-queue-ids | db
>           | size                  | 0
>           | gateway-sender-ids    | ny
> Partition | redundant-copies      | 1
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)