Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Wed, 1 Nov 2017 19:36:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13111534.1508792686000.123886.1509564960307@Atlassian.JIRA>
In-Reply-To: <JIRA.13111534.1508792686000@Atlassian.JIRA>
References: <JIRA.13111534.1508792686000@Atlassian.JIRA> <JIRA.13111534.1508792686601@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-3895) Add Handshake/Message version byte
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 01 Nov 2017 19:36:05 -0000


    [ https://issues.apache.org/jira/browse/GEODE-3895?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16234623#comment-16234623 ] 

ASF GitHub Bot commented on GEODE-3895:
---------------------------------------

kohlmu-pivotal commented on a change in pull request #1001: GEODE-3895: Add Handshake/Message version byte
URL: https://github.com/apache/geode/pull/1001#discussion_r148351585
 
 
 ##########
 File path: geode-core/src/main/java/org/apache/geode/internal/cache/client/protocol/ClientProtocolServiceLoader.java
 ##########
 @@ -48,6 +49,11 @@ public ClientProtocolService lookupService() {
       throw new ServiceLoadingFailureException(
           "There is more than one ClientProtocolService implementation found in JVM; aborting");
     }
-    return clientProtocolServices.get(0);
+    ClientProtocolService clientProtocolService = clientProtocolServices.get(0);
 
 Review comment:
   why could we not convert the `List` to a Map. That way we can easily do a "version lookup" rather than size lookup.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add Handshake/Message version byte
> ----------------------------------
>
>                 Key: GEODE-3895
>                 URL: https://issues.apache.org/jira/browse/GEODE-3895
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Brian Baynes
>            Priority: Major
>
> Add an extra protocol version byte so that the first two bytes will (initially) be 110 followed by 1. The '1' byte will be increased when the HandshakeRequest or Message changes in such a way that we can't make the handshake backward-compatible.
> Ensure that clients on newer versions will have their connections terminated.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)