Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Wed, 29 Nov 2017 17:05:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13089559.1500909598000.346749.1511975100623@Atlassian.JIRA>
In-Reply-To: <JIRA.13089559.1500909598000@Atlassian.JIRA>
References: <JIRA.13089559.1500909598000@Atlassian.JIRA> <JIRA.13089559.1500909598922@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-3288) Replace char* with std::string
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 29 Nov 2017 17:05:05 -0000


    [ https://issues.apache.org/jira/browse/GEODE-3288?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271103#comment-16271103 ] 

ASF GitHub Bot commented on GEODE-3288:
---------------------------------------

dgkimura commented on a change in pull request #160: GEODE-3288: Converts char* to std::string on public API.
URL: https://github.com/apache/geode-native/pull/160#discussion_r153828256
 
 
 ##########
 File path: cppcache/integration-test/TallyListener.hpp
 ##########
 @@ -122,8 +122,8 @@ class TallyListener : public CacheListener {
     if (m_callbackArg != nullptr) {
       auto callbkArg =
           std::dynamic_pointer_cast<CacheableKey>(event.getCallbackArgument());
-      if (strcmp(m_callbackArg->toString()->asChar(),
-                 callbkArg->toString()->asChar()) == 0) {
+      if (strcmp(m_callbackArg->toString().c_str(),
+                 callbkArg->toString().c_str()) == 0) {
 
 Review comment:
   Do we even need `strcmp` anymore?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Replace char* with std::string
> ------------------------------
>
>                 Key: GEODE-3288
>                 URL: https://issues.apache.org/jira/browse/GEODE-3288
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Ernest Burghardt
>
> In all public API headers


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)