Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Fri, 10 Nov 2017 19:59:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13083270.1498683662000.209615.1510343940285@Atlassian.JIRA>
In-Reply-To: <JIRA.13083270.1498683662000@Atlassian.JIRA>
References: <JIRA.13083270.1498683662000@Atlassian.JIRA> <JIRA.13083270.1498683662912@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-3149) Protobuf protocol module will throw
 exceptions on some input
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 10 Nov 2017 19:59:11 -0000


    [ https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247989#comment-16247989 ] 

ASF GitHub Bot commented on GEODE-3149:
---------------------------------------

dgkimura commented on a change in pull request #148: GEODE-3149: Removing the VectorT.hpp header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150325113
 
 
 ##########
 File path: cppcache/include/geode/CacheLoader.hpp
 ##########
 @@ -67,8 +68,8 @@ class CPPCACHE_EXPORT CacheLoader  {
    *
    *@see Region::get .
    */
-  virtual CacheablePtr load(const RegionPtr& rp, const CacheableKeyPtr& key,
-                            const SerializablePtr& aCallbackArgument) = 0;
+  virtual std::shared_ptr<Cacheable> load(const std::shared_ptr<Region>& rp, const std::shared_ptr<CacheableKey>& key,
+                            const std::shared_ptr<Serializable>& aCallbackArgument) = 0;
 
 Review comment:
   format

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> ------------------------------------------------------------
>
>                 Key: GEODE-3149
>                 URL: https://issues.apache.org/jira/browse/GEODE-3149
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>            Reporter: Brian Rowe
>             Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the incoming socket without crashing.  
> Right now closing the socket will cause a crash as we try to process a message from the empty stream (the bug here might be that the server connection shouldn't be trying to process a message here, but the protocol deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT <ServerConnection on port 22514 Thread 0> tid=0x31] Uncaught exception in thread Thread[ServerConnection on port 22514 Thread 0,5,ServerConnection on port 22514]
> java.lang.NullPointerException
> 	at org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
> 	at org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
> 	at org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
> 	at org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> 	at org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
> 	at java.lang.Thread.run(Thread.java:748)
> {code}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)