Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Tue, 7 Nov 2017 17:19:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13082886.1498583105000.171815.1510075140578@Atlassian.JIRA>
In-Reply-To: <JIRA.13082886.1498583105000@Atlassian.JIRA>
References: <JIRA.13082886.1498583105000@Atlassian.JIRA> <JIRA.13082886.1498583105426@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-3136) Replace all public API time values
 with std::chrono types
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Tue, 07 Nov 2017 17:19:04 -0000


    [ https://issues.apache.org/jira/browse/GEODE-3136?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16242437#comment-16242437 ] 

ASF GitHub Bot commented on GEODE-3136:
---------------------------------------

pivotal-jbarrett commented on a change in pull request #144: GEODE-3136: Convert time values to std::chrono::duration.
URL: https://github.com/apache/geode-native/pull/144#discussion_r149442070
 
 
 ##########
 File path: cppcache/src/LocalRegion.cpp
 ##########
 @@ -346,15 +348,16 @@ void LocalRegion::localPut(const CacheableKeyPtr& key,
   GfErrTypeToException("Region::localPut", err);
 }
 
-void LocalRegion::putAll(const HashMapOfCacheable& map, uint32_t timeout,
+void LocalRegion::putAll(const HashMapOfCacheable& map,
+                         std::chrono::milliseconds timeout,
                          const SerializablePtr& aCallbackArgument) {
-  if ((timeout * 1000) >= 0x7fffffff) {
-    throw IllegalArgumentException(
-        "Region::putAll: timeout parameter "
-        "greater than maximum allowed (2^31/1000 i.e 2147483).");
-  }
-  int64_t sampleStartNanos = startStatOpTime();
-  GfErrType err = putAllNoThrow(map, timeout, aCallbackArgument);
+  //  if ((timeout * 1000) >= 0x7fffffff) {
 
 Review comment:
   Shoot, yes!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Replace all public API time values with std::chrono types
> ---------------------------------------------------------
>
>                 Key: GEODE-3136
>                 URL: https://issues.apache.org/jira/browse/GEODE-3136
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Jacob S. Barrett
>            Assignee: Jacob S. Barrett
>
> Remove ambiguity of time values by using [{{std::chrono}}|http://en.cppreference.com/w/cpp/chrono] types in the public API. 


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)