Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 362F1200D42 for ; Fri, 17 Nov 2017 22:03:05 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 348A9160C0A; Fri, 17 Nov 2017 21:03:05 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 7A41C160BE6 for ; Fri, 17 Nov 2017 22:03:04 +0100 (CET) Received: (qmail 3958 invoked by uid 500); 17 Nov 2017 21:03:03 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 3949 invoked by uid 99); 17 Nov 2017 21:03:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 17 Nov 2017 21:03:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id B93A41807A5 for ; Fri, 17 Nov 2017 21:03:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id q1w1ZmNgsQAu for ; Fri, 17 Nov 2017 21:03:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6EA495FDCE for ; Fri, 17 Nov 2017 21:03:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id E7EF4E0E4A for ; Fri, 17 Nov 2017 21:03:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 745FB240DA for ; Fri, 17 Nov 2017 21:03:00 +0000 (UTC) Date: Fri, 17 Nov 2017 21:03:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-3007) Simplify support for custom GFSH commands MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 17 Nov 2017 21:03:05 -0000 [ https://issues.apache.org/jira/browse/GEODE-3007?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1625= 7567#comment-16257567 ]=20 ASF GitHub Bot commented on GEODE-3007: --------------------------------------- jdeppe-pivotal opened a new pull request #1072: Revert "GEODE-3007: Simplif= y support for custom GFSH commands (#1042)" URL: https://github.com/apache/geode/pull/1072 =20 =20 This reverts commit 0e5dd6ba45519463147337c8265db15e8f1840fc. =20 Thank you for submitting a contribution to Apache Geode. =20 In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: =20 ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced i= n the commit message? =20 - [ ] Has your PR been rebased against the latest commit within the targ= et branch (typically `develop`)? =20 - [ ] Is your initial contribution a single, squashed commit? =20 - [ ] Does `gradlew build` run cleanly? =20 - [ ] Have you written or updated unit tests to verify your changes? =20 - [ ] If adding new dependencies to the code, are these dependencies lic= ensed in a way that is compatible for inclusion under [ASF 2.0](http://www.= apache.org/legal/resolved.html#category-a)? =20 ### Note: Please ensure that once the PR is submitted, you check travis-ci for bui= ld issues and submit an update to your PR as soon as possible. If you need help, pleas= e send an email to dev@geode.apache.org. =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Simplify support for custom GFSH commands > ----------------------------------------- > > Key: GEODE-3007 > URL: https://issues.apache.org/jira/browse/GEODE-3007 > Project: Geode > Issue Type: Improvement > Components: docs, gfsh > Reporter: Jared Stewart > Assignee: Jared Stewart > > Geode currently supports three ways to load GFSH commands:=20 > 1. Scan the classpath for commands in "org.apache.geode.management.intern= al.cli.commands=E2=80=9D > 2. Scan the classpath for commands in a package specified by a user via t= he =E2=80=9Cuser-command-packages=E2=80=9D system property.=20 > 3. Scan the classpath for commands registered in files inside META-INF.se= rvices (e.g. "geode-core/src/test/resources/META-INF/services/org.springfra= mework.shell.core.CommandMarker=E2=80=9D)=20 > After the improvements made by GEODE-2989, there is no reason to require = a user to specify the location of their custom commands via one of these me= chanisms. Instead, we should simply scan the entire classpath for any clas= ses implementing CommandMarker (regardless of whatever packages they live i= n). =20 -- This message was sent by Atlassian JIRA (v6.4.14#64029)