geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-4029) Deployed jars may not be correct when multiple locators are in use
Date Thu, 30 Nov 2017 16:57:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272935#comment-16272935
] 

ASF GitHub Bot commented on GEODE-4029:
---------------------------------------

jinmeiliao commented on a change in pull request #1103: GEODE-4029: Deployed jars may not
be correct when multiple locators a…
URL: https://github.com/apache/geode/pull/1103#discussion_r153929515
 
 

 ##########
 File path: geode-core/src/main/java/org/apache/geode/management/internal/configuration/callbacks/ConfigurationChangeListener.java
 ##########
 @@ -41,48 +41,42 @@ public ConfigurationChangeListener(ClusterConfigurationService sharedConfig)
{
     this.sharedConfig = sharedConfig;
   }
 
+  // Don't process the event locally. The action of adding or removing a jar should already
have
+  // been performed by DeployCommand or UndeployCommand.
   @Override
   public void afterUpdate(EntryEvent<String, Configuration> event) {
     super.afterUpdate(event);
-    addOrRemoveJarFromFilesystem(event);
+    if (event.isOriginRemote()) {
+      addOrRemoveJarFromFilesystem(event);
+    }
   }
 
   @Override
   public void afterCreate(EntryEvent<String, Configuration> event) {
     super.afterCreate(event);
-    addOrRemoveJarFromFilesystem(event);
+    if (event.isOriginRemote()) {
 
 Review comment:
   don't need this check.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Deployed jars may not be correct when multiple locators are in use
> ------------------------------------------------------------------
>
>                 Key: GEODE-4029
>                 URL: https://issues.apache.org/jira/browse/GEODE-4029
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>            Reporter: Jens Deppe
>            Assignee: Jens Deppe
>
> When we have more than one locator, if a jar is re-deployed it will not be propagated
correctly to the 'remote' locators. i.e. the locators which are not directly executing the
'deploy' command.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message