geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-4029) Deployed jars may not be correct when multiple locators are in use
Date Thu, 30 Nov 2017 00:48:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-4029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271918#comment-16271918
] 

ASF GitHub Bot commented on GEODE-4029:
---------------------------------------

PurelyApplied commented on a change in pull request #1103: GEODE-4029: Deployed jars may not
be correct when multiple locators a…
URL: https://github.com/apache/geode/pull/1103#discussion_r153959101
 
 

 ##########
 File path: geode-core/src/main/java/org/apache/geode/management/internal/configuration/callbacks/ConfigurationChangeListener.java
 ##########
 @@ -95,6 +89,14 @@ private void addOrRemoveJarFromFilesystem(EntryEvent<String, Configuration>
even
         }
       }
     }
+
+    for (String jarAdded : newJars) {
+      try {
+        sharedConfig.downloadJarFromOtherLocators(group, jarAdded);
+      } catch (Exception e) {
+        logger.error("Unable to add jar: " + jarAdded, e);
 
 Review comment:
   Similarly, is it safe for this and/or the exception above to be swallowed?  Particularly
if you can't add the jar, I imagine this should rethrow.  Or is that something that would
be addressed as a matter of course as enforced by the cluster config?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Deployed jars may not be correct when multiple locators are in use
> ------------------------------------------------------------------
>
>                 Key: GEODE-4029
>                 URL: https://issues.apache.org/jira/browse/GEODE-4029
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>            Reporter: Jens Deppe
>            Assignee: Jens Deppe
>
> When we have more than one locator, if a jar is re-deployed it will not be propagated
correctly to the 'remote' locators. i.e. the locators which are not directly executing the
'deploy' command.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message