geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-4007) Authentication failures/bad handshake should close the socket from the server side
Date Wed, 22 Nov 2017 22:28:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-4007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16263464#comment-16263464
] 

ASF GitHub Bot commented on GEODE-4007:
---------------------------------------

WireBaron commented on a change in pull request #1087: GEODE-4007: Authentication/Handshake
errors should close the socket
URL: https://github.com/apache/geode/pull/1087#discussion_r152692573
 
 

 ##########
 File path: geode-client-protocol/src/main/java/org/apache/geode/internal/protocol/operations/OperationHandler.java
 ##########
 @@ -30,7 +31,11 @@
   /**
    * Decode the message, deserialize contained values using the serialization service, do
the work
    * indicated on the provided cache, and return a response.
+   *
+   * @throws ConnectionStateException if the connection is in an invalid state for the operation
in
+   *         question.
    */
   Result<Resp, ErrorResp> process(SerializationService serializationService, Req request,
-      MessageExecutionContext messageExecutionContext) throws InvalidExecutionContextException;
+      MessageExecutionContext messageExecutionContext)
+      throws InvalidExecutionContextException, ConnectionStateException;
 
 Review comment:
   ConnectionStateException is newly thrown in this change, Galen made the observation that
the code we're using to handle this inside the OpHandler is identical to the catch code we're
using in the function calling this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Authentication failures/bad handshake should close the socket from the server side
> ----------------------------------------------------------------------------------
>
>                 Key: GEODE-4007
>                 URL: https://issues.apache.org/jira/browse/GEODE-4007
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>            Reporter: Brian Rowe
>
> Ensure after failed auth/handshake the server (after sending error response) closes the
socket and cleans up.
> While going over the code together, it looks like maybe authentication errors simply
leave the socket in a state where it is expecting another authentication request. It might
be better to close the socket from the server side for various error conditions like a failed
handshake or authentication.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message