geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-4007) Authentication failures/bad handshake should close the socket from the server side
Date Wed, 22 Nov 2017 19:08:00 GMT


ASF GitHub Bot commented on GEODE-4007:

WireBaron opened a new pull request #1087: GEODE-4007: Authentication/Handshake errors should
close the socket
   @PivotalSarge @galen-pivotal @bschuchardt @upthewaterspout 
   This will cause the connection to be closed whenever a handshake or
    authentication message fails.
   The connection will also be broken if we ever receive an unexpected handshake or
    authenticantication message.
   Signed-off-by: Brian Rowe <>
   Thank you for submitting a contribution to Apache Geode.
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   - [x] Has your PR been rebased against the latest commit within the target branch (typically
   - [x] Is your initial contribution a single, squashed commit?
   - [x] Does `gradlew build` run cleanly?
   - [x] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Authentication failures/bad handshake should close the socket from the server side
> ----------------------------------------------------------------------------------
>                 Key: GEODE-4007
>                 URL:
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>            Reporter: Brian Rowe
> Ensure after failed auth/handshake the server (after sending error response) closes the
socket and cleans up.
> While going over the code together, it looks like maybe authentication errors simply
leave the socket in a state where it is expecting another authentication request. It might
be better to close the socket from the server side for various error conditions like a failed
handshake or authentication.

This message was sent by Atlassian JIRA

View raw message