geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3987) Enforce the uniqueness of a single gateway-receiver per member
Date Wed, 22 Nov 2017 10:53:00 GMT


ASF GitHub Bot commented on GEODE-3987:

jujoramos opened a new pull request #1086: GEODE-3987: enforce GatewayReceiver uniqueness
per member.
   Enforcements added in the different creation entry points to prevent
   the existence of more than one gateway receiver per member.
   - Added several XML parsing tests.
   - Added integration and Junit tests.
   - DTD allows 0 or 1 occurrences of the <gateway-receiver> element.
   - XSD allows 0 or 1 occurrences of the <gateway-receiver> element.
   - GatewayReceiverFactory checks before creating new gateway receiver.
   - Existing tests modified to use new MemberVM/GfshCommandRule features.
   Thank you for submitting a contribution to Apache Geode.
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   - [X] Has your PR been rebased against the latest commit within the target branch (typically
   - [X] Is your initial contribution a single, squashed commit?
   - [X] Does `gradlew build` run cleanly?
   - [X] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Enforce the uniqueness of a single gateway-receiver per member
> --------------------------------------------------------------
>                 Key: GEODE-3987
>                 URL:
>             Project: Geode
>          Issue Type: Bug
>            Reporter: Juan José Ramos Cassella
>            Assignee: Juan José Ramos Cassella
> Within the documentation, both in [Configure Gateway Receivers|]
and [gfsh create gateway-receiver|],
we state that only one {{gateway-receiver}} is allowed per member. However, there is no enforcement
of this rule within the code nor within the schema for the {{cache.xml}} file, so the user
might end up having more than one {{gateway-receiver}} per host.
> It's unknown which {{gateway-receiver}} is going to be used after a restart, making it
hard to configure firewall rules between clusters, if any. The following exception is also
printed in the logs whenever we try to register (only the first one is succesfull) the MBean
for the {{gateway-receiver}}:
> {noformat}
> [warning 2017/11/16 15:27:46.156 PST host1-server1 <Function Execution Processor1>
tid=0x44] GemFire:service=GatewayReceiver,type=Member,member=host1-server1
> 	at
> 	at
> 	at
> 	at
> 	at
> 	at org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(
> 	at org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(
> 	at org.apache.geode.internal.cache.wan.GatewayReceiverImpl.start(
> 	at org.apache.geode.internal.cache.wan.GatewayReceiverFactoryImpl.create(
> 	at
> 	at
> 	at org.apache.geode.internal.cache.MemberFunctionStreamingMessage.process(
> 	at org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(
> 	at org.apache.geode.distributed.internal.DistributionMessage$
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(
> 	at java.util.concurrent.ThreadPoolExecutor$
> 	at org.apache.geode.distributed.internal.DistributionManager.runUntilShutdown(
> 	at org.apache.geode.distributed.internal.DistributionManager$9$
> 	at
> Caused by: GemFire:service=GatewayReceiver,type=Member,member=host1-server1
> 	at com.sun.jmx.mbeanserver.Repository.addMBean(
> 	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerWithRepository(
> 	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerDynamicMBean(
> 	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerObject(
> 	at com.sun.jmx.interceptor.DefaultMBeanServerInterceptor.registerMBean(
> 	at com.sun.jmx.mbeanserver.JmxMBeanServer.registerMBean(
> 	at
> 	... 18 more
> {noformat}
> The fix implies:
> . Change the {{maxOccurs}} attribute from {{unbounded}} to {{1}} in the {{cache-1.0.xsd}}
> . Add the validation to the {{GatewayReceiverFactoryImpl.create()}} method, as this is
the single entry point for {{GatewayReceiver}} instance creations.

This message was sent by Atlassian JIRA

View raw message