geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3977) .NET QueryService templating should match usage
Date Thu, 16 Nov 2017 19:07:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16255800#comment-16255800
] 

ASF GitHub Bot commented on GEODE-3977:
---------------------------------------

pivotal-jbarrett commented on a change in pull request #154: GEODE-3977: Modifying the QueryService
template
URL: https://github.com/apache/geode-native/pull/154#discussion_r151507982
 
 

 ##########
 File path: clicache/src/QueryService.hpp
 ##########
 @@ -51,7 +60,7 @@ namespace Apache
       /// <summary>
       /// Provides a query service.
       /// </summary>
-      generic<class TKey, class TResult>
+      generic<class TResult>
 
 Review comment:
   Additionally methods like `CloseCqs` operates on all CQs, not just the ones that match
the `TResult` of the class.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> .NET QueryService templating should match usage
> -----------------------------------------------
>
>                 Key: GEODE-3977
>                 URL: https://issues.apache.org/jira/browse/GEODE-3977
>             Project: Geode
>          Issue Type: Bug
>          Components: native client
>            Reporter: Ernest Burghardt
>
> QueryService uses generics
>  generic<class TKey, class TResult>
>       //generic<class TResult>
>       Query<TResult>^ QueryService<TKey, TResult>::NewQuery(String^ query)
> but only TResult is used and this can be confusing to the user/developer...



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message