geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3969) Protobuf protocol requests includes a CallbackArgs field
Date Fri, 17 Nov 2017 22:54:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257707#comment-16257707
] 

ASF GitHub Bot commented on GEODE-3969:
---------------------------------------

WireBaron commented on a change in pull request #1047: GEODE-3969: Remove CallbackArgs from
protobuf requests
URL: https://github.com/apache/geode/pull/1047#discussion_r151807947
 
 

 ##########
 File path: geode-protobuf/src/main/proto/v1/clientProtocol.proto
 ##########
 @@ -35,7 +35,6 @@ message Message {
 }
 
 message Request {
-    CallbackArguments callbackArg = 1;
     oneof requestAPI {
         PutRequest putRequest = 2;
 
 Review comment:
   I decided to address this by changing the requestAPI field numbers to start at 10.  This
lets us add some fields to these messages in the future without having to worry about colliding
with the requestAPI field numbers (as we do expect to keep adding new types of messages here).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Protobuf protocol requests includes a CallbackArgs field
> --------------------------------------------------------
>
>                 Key: GEODE-3969
>                 URL: https://issues.apache.org/jira/browse/GEODE-3969
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>            Reporter: Brian Rowe
>
> We eventually want to support allowing clients to pass arguments to cache listeners in
their requests, but this functionality is not going to be present in v1.  Having this field
is therefore misleading and it should be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message