geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3969) Protobuf protocol requests includes a CallbackArgs field
Date Fri, 10 Nov 2017 21:32:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248047#comment-16248047
] 

ASF GitHub Bot commented on GEODE-3969:
---------------------------------------

WireBaron opened a new pull request #1047: GEODE-3969: Remove CallbackArgs from protobuf requests
URL: https://github.com/apache/geode/pull/1047
 
 
   @galen-pivotal @kohlmu-pivotal @bschuchardt @PivotalSarge 
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Protobuf protocol requests includes a CallbackArgs field
> --------------------------------------------------------
>
>                 Key: GEODE-3969
>                 URL: https://issues.apache.org/jira/browse/GEODE-3969
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>            Reporter: Brian Rowe
>
> We eventually want to support allowing clients to pass arguments to cache listeners in
their requests, but this functionality is not going to be present in v1.  Having this field
is therefore misleading and it should be removed.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message