geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3961) Show metrics disregards specified --categories for CacheServer (--port option related) metrics
Date Tue, 14 Nov 2017 19:09:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251991#comment-16251991
] 

ASF GitHub Bot commented on GEODE-3961:
---------------------------------------

PurelyApplied closed pull request #1055: GEODE-3961: Correct test after bad rebase.
URL: https://github.com/apache/geode/pull/1055
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowMetricsCommandIntegrationTest.java
b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowMetricsCommandIntegrationTest.java
index f17c681250..b18af6ccbf 100644
--- a/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowMetricsCommandIntegrationTest.java
+++ b/geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/ShowMetricsCommandIntegrationTest.java
@@ -32,8 +32,8 @@
 import org.apache.geode.cache.RegionShortcut;
 import org.apache.geode.internal.logging.LogService;
 import org.apache.geode.test.junit.categories.IntegrationTest;
-import org.apache.geode.test.junit.rules.GfshShellConnectionRule;
-import org.apache.geode.test.junit.rules.GfshShellConnectionRule.PortType;
+import org.apache.geode.test.junit.rules.GfshCommandRule;
+import org.apache.geode.test.junit.rules.GfshCommandRule.PortType;
 import org.apache.geode.test.junit.rules.ServerStarterRule;
 
 @Category(IntegrationTest.class)
@@ -48,7 +48,7 @@
           .withName(MEMBER_NAME).withJMXManager().withEmbeddedLocator().withAutoStart();
 
   @Rule
-  public GfshShellConnectionRule gfsh = new GfshShellConnectionRule();
+  public GfshCommandRule gfsh = new GfshCommandRule();
 
   @Test
   public void everyCategoryHasAUseCase() throws Exception {


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Show metrics disregards specified --categories for CacheServer (--port option related)
metrics 
> -----------------------------------------------------------------------------------------------
>
>                 Key: GEODE-3961
>                 URL: https://issues.apache.org/jira/browse/GEODE-3961
>             Project: Geode
>          Issue Type: Bug
>          Components: docs, gfsh
>            Reporter: Patrick Rhomberg
>            Assignee: Patrick Rhomberg
>
> Those CacheServer metric categories ({{query}}, {{notification}}, and {{cache-server}})
are not checked against those categories specified by the user and are only checked against
the cache server bean being non-null (implicitly: that the port was provided and valid).
> For unification and consistency, these categories should not be displayed when the {{--categories}}
option is specified and excludes them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message