geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3961) Show metrics disregards specified --categories for CacheServer (--port option related) metrics
Date Tue, 14 Nov 2017 18:03:02 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3961?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16251843#comment-16251843
] 

ASF subversion and git services commented on GEODE-3961:
--------------------------------------------------------

Commit 69143c14f43f8cee514e36630bb495b3c106bcec in geode's branch refs/heads/develop from
[~prhomberg]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=69143c1 ]

GEODE-3961: Refactor ShowMetricsCommand to handle --categories uniformly

* GEODE-3961: Refactor ShowMetricsCommand to behave uniformly when --categories is provided.

* The ShowMetricsCommand has been almost entirely refactored, but with minimal change to existing
behavior.
* The category "cache-server" has been renamed to "cacheserver"
* The "query" category now only lists once instead of twice.
* Category checking is now performed by the client, not the server.
* Alphabetized excludedClasses.txt


> Show metrics disregards specified --categories for CacheServer (--port option related)
metrics 
> -----------------------------------------------------------------------------------------------
>
>                 Key: GEODE-3961
>                 URL: https://issues.apache.org/jira/browse/GEODE-3961
>             Project: Geode
>          Issue Type: Bug
>            Reporter: Patrick Rhomberg
>
> Those CacheServer metric categories ({{query}}, {{notification}}, and {{cache-server}})
are not checked against those categories specified by the user and are only checked against
the cache server bean being non-null (implicitly: that the port was provided and valid).
> For unification and consistency, these categories should not be displayed when the {{--categories}}
option is specified and excludes them.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message