geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3961) Show metrics disregards specified --categories for CacheServer (--port option related) metrics
Date Fri, 10 Nov 2017 21:52:00 GMT


ASF GitHub Bot commented on GEODE-3961:

jinmeiliao commented on a change in pull request #1046: GEODE-3961: Refactor ShowMetricsCommand
to behave uniformly...

 File path: geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/
 @@ -16,47 +16,156 @@
 import static org.assertj.core.api.Assertions.assertThat;
-import static org.mockito.Mockito.spy;
+import java.util.Arrays;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Set;
+import org.apache.logging.log4j.Logger;
+import org.junit.ClassRule;
 import org.junit.Rule;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
-import org.apache.geode.test.junit.categories.UnitTest;
-import org.apache.geode.test.junit.rules.GfshParserRule;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.internal.logging.LogService;
+import org.apache.geode.test.junit.categories.IntegrationTest;
+import org.apache.geode.test.junit.rules.GfshShellConnectionRule;
+import org.apache.geode.test.junit.rules.GfshShellConnectionRule.PortType;
+import org.apache.geode.test.junit.rules.ServerStarterRule;
 public class ShowMetricsCommandJUnitTest {
 Review comment:
   This is an integration test. It's not a JUnit test. Rename this to be ShowMetricsCommandIntegrationTest

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Show metrics disregards specified --categories for CacheServer (--port option related)
> -----------------------------------------------------------------------------------------------
>                 Key: GEODE-3961
>                 URL:
>             Project: Geode
>          Issue Type: Bug
>            Reporter: Patrick Rhomberg
> Those CacheServer metric categories ({{query}}, {{notification}}, and {{cache-server}})
are not checked against those categories specified by the user and are only checked against
the cache server bean being non-null (implicitly: that the port was provided and valid).
> For unification and consistency, these categories should not be displayed when the {{--categories}}
option is specified and excludes them.

This message was sent by Atlassian JIRA

View raw message