geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3952) Improve spotless to more closely adhere to established style guidelines.
Date Fri, 03 Nov 2017 17:46:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16238062#comment-16238062
] 

ASF GitHub Bot commented on GEODE-3952:
---------------------------------------

PurelyApplied commented on issue #1015: GEODE-3952: Improve Spotless
URL: https://github.com/apache/geode/pull/1015#issuecomment-341777335
 
 
   For ease of integration, the changes to spotless and the application of spotless have been
separated.  The second commit will likely need to be redone before merging to account for
any changes between rebases.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Improve spotless to more closely adhere to established style guidelines. 
> -------------------------------------------------------------------------
>
>                 Key: GEODE-3952
>                 URL: https://issues.apache.org/jira/browse/GEODE-3952
>             Project: Geode
>          Issue Type: Improvement
>            Reporter: Patrick Rhomberg
>
> Spotless currently addresses whitespacing and very little else.  It could be expanded
to clean up the more glaring (in my opinion) broken windows.  This includes:
> * Adherence to the established import ordering given in `[geode]/etc/`
> * Adherence to the established modifier ordering given in the Google Java Style guide,
which we largely adopt.  (e.g., `public static int` over `static public int`.)
> * Removal of some dead code, particularly commented-out import statements.
> * Improvements to whitespace handling, particularly to end files in a single carriage
return and to trim whitespace from the end of each line.
> Increase to compile time is trivial, approximately ten seconds in the worst case.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message