geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3938) Allow query parameters within the to_date preset query function
Date Wed, 01 Nov 2017 13:16:00 GMT


ASF GitHub Bot commented on GEODE-3938:

jujoramos opened a new pull request #1003: Fix for GEODE-3938
   GEODE-3938: Allow query parameters within the to_date preset query function.
     . Added unit tests.
     . Changed oql.g to allow both 'stringLiteral' and 'queryParam' within the do_date preset
function definition.
   Thank you for submitting a contribution to Apache Geode.
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   ### For all changes:
   - [X] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   - [X] Has your PR been rebased against the latest commit within the target branch (typically
   - [X] Is your initial contribution a single, squashed commit?
   - [X] Does `gradlew build` run cleanly?
   - [X] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Allow query parameters within the to_date preset query function
> ---------------------------------------------------------------
>                 Key: GEODE-3938
>                 URL:
>             Project: Geode
>          Issue Type: New Feature
>          Components: querying
>            Reporter: Juan José Ramos Cassella
>            Assignee: Juan José Ramos Cassella
> Currently the {{to_date}} preset query function doesn't allow the user to pass the date
to format as a query parameter, which forces the user application to add boilerplate code
to manually parse the date.
> Apparently there's no internal blockers preventing such a feature to be enabled, and
the change just implies a small change in {{oql.g}}:
> {code}
> conversionExpr :
>   (
>     ...
>         |
>            (  
>               (
>                "to_date"^<AST=org.apache.geode.cache.query.internal.parse.ASTConversionExpr>
>               )
>               TOK_LPAREN!
>               (stringLiteral | queryParam) TOK_COMMA! stringLiteral
>               TOK_RPAREN! 
>            )    
>     ...
>   )
>     ;
> {code}

This message was sent by Atlassian JIRA

View raw message