geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3793) Test/prove out new protocol's versioning/message additions
Date Tue, 14 Nov 2017 22:20:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3793?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16252538#comment-16252538
] 

ASF GitHub Bot commented on GEODE-3793:
---------------------------------------

WireBaron commented on a change in pull request #1058: GEODE-3793: Refactor version validation
into testable class.
URL: https://github.com/apache/geode/pull/1058#discussion_r150980603
 
 

 ##########
 File path: geode-protobuf/src/test/java/org/apache/geode/internal/protocol/protobuf/v1/operations/VersionValidatorJUnitTest.java
 ##########
 @@ -0,0 +1,60 @@
+package org.apache.geode.internal.protocol.protobuf.v1.operations;
+
+import static org.junit.Assert.assertFalse;
+import static org.junit.Assert.assertTrue;
+
+import org.junit.Test;
+import org.junit.experimental.categories.Category;
+
+import org.apache.geode.internal.protocol.protobuf.v1.ConnectionAPI;
+import org.apache.geode.test.junit.categories.UnitTest;
+
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
 
 Review comment:
   Doesn't this need to come before the imports?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Test/prove out new protocol's versioning/message additions
> ----------------------------------------------------------
>
>                 Key: GEODE-3793
>                 URL: https://issues.apache.org/jira/browse/GEODE-3793
>             Project: Geode
>          Issue Type: Task
>          Components: client/server
>            Reporter: Geode Integration
>
> Test and prove out the new protocol's versioning/addition of messages.
> Expected: 
> Clients on a different major version will receive a helpful error message (and are not
supported)
> Clients on the same major version (but possibly different minor version) will be supported.
> So, devs should be able to add new messages to the protocol, bumping the minor version,
and clients without knowledge of that message should still be supported (as long as they're
on the same major version).



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message