geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3793) Test/prove out new protocol's versioning/message additions
Date Tue, 14 Nov 2017 21:26:00 GMT


ASF GitHub Bot commented on GEODE-3793:

PivotalSarge opened a new pull request #1058: GEODE-3793: Refactor version validation into
testable class.
   Thank you for submitting a contribution to Apache Geode.
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   - [x] Has your PR been rebased against the latest commit within the target branch (typically
   - [x] Is your initial contribution a single, squashed commit?
   - [x] Does `gradlew build` run cleanly?
   - [x] Have you written or updated unit tests to verify your changes?
   - [n/a] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Test/prove out new protocol's versioning/message additions
> ----------------------------------------------------------
>                 Key: GEODE-3793
>                 URL:
>             Project: Geode
>          Issue Type: Task
>          Components: client/server
>            Reporter: Geode Integration
> Test and prove out the new protocol's versioning/addition of messages.
> Expected: 
> Clients on a different major version will receive a helpful error message (and are not
> Clients on the same major version (but possibly different minor version) will be supported.
> So, devs should be able to add new messages to the protocol, bumping the minor version,
and clients without knowledge of that message should still be supported (as long as they're
on the same major version).

This message was sent by Atlassian JIRA

View raw message