geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3645) Update API CacheFactory::create to return cache object
Date Wed, 29 Nov 2017 19:38:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16271416#comment-16271416
] 

ASF GitHub Bot commented on GEODE-3645:
---------------------------------------

dgkimura commented on a change in pull request #159: GEODE-3645: Update CacheFactory::create
to return Cache by value
URL: https://github.com/apache/geode-native/pull/159#discussion_r153893137
 
 

 ##########
 File path: clicache/src/DistributedSystem.cpp
 ##########
 @@ -140,9 +140,9 @@ namespace Apache
 
         // this we are calling after all .NET initialization required in
         // each AppDomain
-        auto nativeptr = native::DistributedSystem::create(mg_name.CharPtr, cache->GetNative().get(),
+        auto nativeptr = native::DistributedSystem::create(mg_name.CharPtr,
                                                             config->GetNative());
-        nativeptr->connect();
+        nativeptr->connect(cache->GetNative().get());
 
 Review comment:
   This was split because of circular constructor dependency between CacheImpl and DistributedSystem.
 DistributedSystem uses CacheImpl for StatisticsManager.  It worked before when DistributedSystem
took a Cache, but we can't do that anymore since Cache may be moved.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Update API CacheFactory::create to return cache object
> ------------------------------------------------------
>
>                 Key: GEODE-3645
>                 URL: https://issues.apache.org/jira/browse/GEODE-3645
>             Project: Geode
>          Issue Type: New Feature
>          Components: native client
>            Reporter: David Kimura
>
> As an application developer I want to control the stack vs heap allocation of my cache
object.  If we change CacheFactory::create to return a cache object then the application user
can pick an allocation scheme.  This also allows application developers to bypass smart pointer
complexity until the developer deems them necessary.
> Example:
> {noformat}
> auto cache = CacheFactory::createFactory().create();
> auto cacheptr = std::make_shared<Cache>(CacheFactory::createFactory().create());
> {noformat}
> Difficulty of implementation is due to Cache/CacheImpl circular dependency.  Here are
a few examples of various approaches to consider:
> https://gist.github.com/pivotal-jbarrett/52ba9ec5de0b494368d1c5282ef188ef
> https://gist.github.com/pivotal-jbarrett/c48ffff3f7f41b187f0ed8c80108aa6a
> Here are the related email threads of interest:
> http://markmail.org/message/in5e337npq5euslh
> http://markmail.org/message/lp2rx2rtyblg72fv



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message