geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3599) refactor Message classes process methods to not call CacheFactory.getInstance
Date Wed, 08 Nov 2017 00:57:00 GMT


ASF GitHub Bot commented on GEODE-3599:

dschneider-pivotal opened a new pull request #1037: GEODE-3599: remove getInstance calls
   DM.getCache is now used instead
   Thank you for submitting a contribution to Apache Geode.
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically
   - [ ] Is your initial contribution a single, squashed commit?
   - [ ] Does `gradlew build` run cleanly?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> refactor Message classes process methods to not call CacheFactory.getInstance
> -----------------------------------------------------------------------------
>                 Key: GEODE-3599
>                 URL:
>             Project: Geode
>          Issue Type: Sub-task
>          Components: regions
>            Reporter: Darrel Schneider
>            Assignee: Darrel Schneider
> The following message classes all call CacheFactory.getInstance from their process methods
but should instead call "dm.getCache":
> org.apache.geode.internal.cache.CreateRegionProcessor.CreateRegionMessage.process(DistributionManager)
> org.apache.geode.internal.cache.persistence.MembershipFlushRequest.process(DistributionManager)
> org.apache.geode.internal.cache.persistence.MembershipViewRequest.process(DistributionManager)
> org.apache.geode.internal.cache.persistence.PersistentStateQueryMessage.process(DistributionManager)
> org.apache.geode.internal.cache.persistence.PrepareNewPersistentMemberMessage.process(DistributionManager)
> org.apache.geode.internal.cache.persistence.RemovePersistentMemberMessage.process(DistributionManager)
> org.apache.geode.internal.cache.SearchLoadAndWriteProcessor.NetWriteRequestMessage.process(DistributionManager)

This message was sent by Atlassian JIRA

View raw message