geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3591) ClientInterestMessageImpl constructor should not call CacheFactory.getAnyInstance
Date Wed, 08 Nov 2017 22:11:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3591?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244818#comment-16244818
] 

ASF subversion and git services commented on GEODE-3591:
--------------------------------------------------------

Commit 44f449c9abd3d0d047c15bec9395e9e8bfaaaec3 in geode's branch refs/heads/develop from
[~dschneider]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=44f449c ]

GEODE-3591: remove getAnyInstance call (#1027)

Now the DistributedSystem is passed in to the constructor.

> ClientInterestMessageImpl constructor should not call CacheFactory.getAnyInstance
> ---------------------------------------------------------------------------------
>
>                 Key: GEODE-3591
>                 URL: https://issues.apache.org/jira/browse/GEODE-3591
>             Project: Geode
>          Issue Type: Sub-task
>          Components: client queues
>            Reporter: Darrel Schneider
>            Assignee: Darrel Schneider
>             Fix For: 1.4.0
>
>
> The constructor is calling it to get the distributed system.
> The only caller of this constructor is: org.apache.geode.internal.cache.tier.sockets.CacheClientProxy.enqueueInterestRegistrationMessage(ClientInterestMessageImpl)
> and it could instead just pass the distributed system in by passing "this._cache.getDistributedSystem()".



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message