geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3571) API should move from factory pattern to builder pattern and fluent model
Date Tue, 28 Nov 2017 20:58:00 GMT


ASF GitHub Bot commented on GEODE-3571:

pivotal-jbarrett commented on a change in pull request #158: feature/GEODE-3571

 File path: clicache/integration-test/AttributesFactoryTestsN.cs
 @@ -24,20 +24,35 @@ namespace Apache.Geode.Client.UnitTests
   using NUnit.Framework;
   using Apache.Geode.DUnitFramework;
-  using Apache.Geode.Client;
   public class AttributesFactoryTests : UnitTests
+    private UnitProcess m_client1, m_client2;
+    protected override ClientBase[] GetClients()
 Review comment:
   Why did this test require adding clients? As far as I can tell all the testing runs local
to the test runner and are not invoked in remote clients.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> API should move from factory pattern to builder pattern and fluent model
> ------------------------------------------------------------------------
>                 Key: GEODE-3571
>                 URL:
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Mark Hanson
> Discussion here
> The basic idea is to move away from the creation of generic objects which are then further
specified to  specifying the object in advance then creating the more specific object.
> This in addition to using a model where with each attribute set on an object, the this
pointer is provided as the return value. This allows call chaining.
> Obvious target changes include 
> CacheFactory
> DistributedSystem
> AttributesFactory

This message was sent by Atlassian JIRA

View raw message