geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3571) API should move from factory pattern to builder pattern and fluent model
Date Mon, 27 Nov 2017 20:59:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267530#comment-16267530
] 

ASF GitHub Bot commented on GEODE-3571:
---------------------------------------

mhansonp commented on a change in pull request #158: feature/GEODE-3571
URL: https://github.com/apache/geode-native/pull/158#discussion_r153320871
 
 

 ##########
 File path: clicache/src/impl/CacheWriter.hpp
 ##########
 @@ -76,8 +76,7 @@ namespace Apache
             RegionEvent<TKey, TValue> gevent(ev->GetNative());
             return m_writer->BeforeRegionDestroy(%gevent);
           }
-          
-          virtual void Close(Apache::Geode::Client::Region<Object^, Object^>^ region)
override
+          virtual void Close(Apache::Geode::Client::Region<Object^, Object^>^ region)
 
 Review comment:
   I know it is supposed to do that if someone in advertently changes the base function prototype,
that is why I didn't intend to check that in.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> API should move from factory pattern to builder pattern and fluent model
> ------------------------------------------------------------------------
>
>                 Key: GEODE-3571
>                 URL: https://issues.apache.org/jira/browse/GEODE-3571
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Mark Hanson
>
> Discussion here http://markmail.org/thread/femkjloasj4yzvoj
> The basic idea is to move away from the creation of generic objects which are then further
specified to  specifying the object in advance then creating the more specific object.
> This in addition to using a model where with each attribute set on an object, the this
pointer is provided as the return value. This allows call chaining.
> Obvious target changes include 
> CacheFactory
> DistributedSystem
> AttributesFactory



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message