geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3539) Add more test coverage for p2p commands
Date Thu, 16 Nov 2017 00:42:00 GMT


ASF GitHub Bot commented on GEODE-3539:

jinmeiliao commented on a change in pull request #1052: GEODE-3539: Add missing test coverage
for 'list regions' and 'describe region' commands

 File path: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/
 @@ -110,4 +108,17 @@ public Result listRegion(
     return result;
+  public static class ListRegionInterceptor extends AbstractCliAroundInterceptor {
 Review comment:
   You probably did not rebase to the current develop, I just made a change in CommandExecutor
to process UserErrorException differently than general exception. That would probably ease
your concern. 
   The getMemberXXX call would have to throw an exception anyway to catch the cases where
some commands do not do that validation in their interceptors. 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Add more test coverage for p2p commands
> ---------------------------------------
>                 Key: GEODE-3539
>                 URL:
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh
>            Reporter: Jinmei Liao
> Add more command tests that would eventually get rid of the legacy tests.

This message was sent by Atlassian JIRA

View raw message