geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3539) Add more test coverage for p2p commands
Date Tue, 14 Nov 2017 16:32:00 GMT


ASF GitHub Bot commented on GEODE-3539:

jinmeiliao commented on a change in pull request #1052: GEODE-3539: Add missing test coverage
for 'list regions' and 'describe region' commands

 File path: geode-core/src/main/java/org/apache/geode/management/internal/cli/commands/
 @@ -110,4 +108,17 @@ public Result listRegion(
     return result;
+  public static class ListRegionInterceptor extends AbstractCliAroundInterceptor {
 Review comment:
   the call of getMember or findMember inside the command will throw an exception if both
are set, so we don't really need to do the check here. I admit that this brings the validation
to the client side, but it's a bit of a redundant code. I think we can afford to make that
check on the server side if it makes the code a little cleaner.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Add more test coverage for p2p commands
> ---------------------------------------
>                 Key: GEODE-3539
>                 URL:
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh
>            Reporter: Jinmei Liao
> Add more command tests that would eventually get rid of the legacy tests.

This message was sent by Atlassian JIRA

View raw message