geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3539) Add more test coverage for p2p commands
Date Thu, 09 Nov 2017 18:21:00 GMT


ASF GitHub Bot commented on GEODE-3539:

jinmeiliao opened a new pull request #1040: GEODE-3539: cleanup GfshCommand and refactor tests
   * remove more try catch blocks in commands
   * make GfshCommand a pure wrapper around CliUtil for easy mocking
   Thank you for submitting a contribution to Apache Geode.
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically
   - [ ] Is your initial contribution a single, squashed commit?
   - [ ] Does `gradlew build` run cleanly?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Add more test coverage for p2p commands
> ---------------------------------------
>                 Key: GEODE-3539
>                 URL:
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh
>            Reporter: Jinmei Liao
> Add more command tests that would eventually get rid of the legacy tests.

This message was sent by Atlassian JIRA

View raw message