geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3539) Add more test coverage for p2p commands
Date Wed, 08 Nov 2017 00:56:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3539?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16243193#comment-16243193
] 

ASF GitHub Bot commented on GEODE-3539:
---------------------------------------

jinmeiliao commented on a change in pull request #1024: GEODE-3539: Restore test coverage
for 'describe connection' command.
URL: https://github.com/apache/geode/pull/1024#discussion_r149549846
 
 

 ##########
 File path: geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/DescribeConnectionCommandJUnitTest.java
 ##########
 @@ -49,13 +49,17 @@
   public GfshShellConnectionRule gfsh = new GfshShellConnectionRule();
 
   @Test
-  public void executeWhileConnected() throws Exception {
-    // Depending on configuration, the host may resolve its local IP
-    // to the alias present in /etc/hosts or use its internal host name.
-    // Check for these first.
-    gfsh.connectAndVerify(locator);
-    gfsh.executeAndAssertThat("describe connection")
-        .tableHasColumnWithValuesContaining("Connection Endpoints", gfsh.getGfsh().getOperationInvoker().toString());
+  public void describeJmxConnection() throws Exception {
+    gfsh.connectAndVerify(locator.getJmxPort(), GfshShellConnectionRule.PortType.jmxManager);
+    gfsh.executeAndAssertThat("describe connection").tableHasColumnWithValuesContaining(
+        "Connection Endpoints", gfsh.getGfsh().getOperationInvoker().toString());
+  }
+
+  @Test
+  public void describeHttpConnection() throws Exception {
 
 Review comment:
   if this test is not in geode-web or geode-assembly, I think this would fail. I don't think
it would necessary to test http. the assertions are all the same.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add more test coverage for p2p commands
> ---------------------------------------
>
>                 Key: GEODE-3539
>                 URL: https://issues.apache.org/jira/browse/GEODE-3539
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh
>            Reporter: Jinmei Liao
>
> Add more command tests that would eventually get rid of the legacy tests.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message