geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3341) Refactor DiskStoreCommandsDUnitTest to use test rules
Date Wed, 15 Nov 2017 20:58:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3341?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16254168#comment-16254168
] 

ASF GitHub Bot commented on GEODE-3341:
---------------------------------------

jinmeiliao commented on a change in pull request #1062: GEODE-3341: Convert DiskStoreCommandsDUnitTest
to use gfsh rules
URL: https://github.com/apache/geode/pull/1062#discussion_r151249238
 
 

 ##########
 File path: geode-core/src/test/java/org/apache/geode/test/junit/rules/GfshCommandRule.java
 ##########
 @@ -265,4 +267,8 @@ public File getWorkingDir() {
   public enum PortType {
     locator, jmxManager, http
   }
+
+  public CommandResult getCommandResult() {
+    return commandResult;
 
 Review comment:
   instead of expose this result, it would be better to add another method in CommandResultAssert
object to assert what you need to do.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refactor DiskStoreCommandsDUnitTest to use test rules
> -----------------------------------------------------
>
>                 Key: GEODE-3341
>                 URL: https://issues.apache.org/jira/browse/GEODE-3341
>             Project: Geode
>          Issue Type: Sub-task
>          Components: tests
>    Affects Versions: 1.2.0
>            Reporter: Emily Yeh
>            Assignee: Jens Deppe
>
> {{DiskStoreCommandsDUnitTest}} is using {{CliCommandTestBase}}, which is a deprecated
class. It should be refactored to use more current test rules.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message