geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3149) Protobuf protocol module will throw exceptions on some input
Date Fri, 10 Nov 2017 22:30:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248100#comment-16248100
] 

ASF GitHub Bot commented on GEODE-3149:
---------------------------------------

mhansonp commented on a change in pull request #148: GEODE-3149: Removing the VectorT.hpp
header file and typedefs
URL: https://github.com/apache/geode-native/pull/148#discussion_r150351974
 
 

 ##########
 File path: clicache/src/CacheableBuiltins.hpp
 ##########
 @@ -386,20 +386,20 @@ namespace Apache
            }                                                                     \
            \
            internal:                                                               \
-           static IGeodeSerializable^ Create(native::SerializablePtr obj)            \
+           static IGeodeSerializable^ Create(std::shared_ptr<native::Serializable>
obj)            \
            {                                                                     \
            return (obj != nullptr ? gcnew m(obj) : nullptr);                   \
            }                                                                     \
            \
            private:                                                                \
-             inline m(native::SerializablePtr nativeptr)                            \
+             inline m(std::shared_ptr<native::Serializable> nativeptr)            
               \
               : CacheableBuiltinKey(nativeptr) { }                                \
       };
 
 
 #define _GFCLI_CACHEABLE_ARRAY_DEF_NEW(m, mt)                                    \
       ref class m : public CacheableBuiltinArray<            \
-        native::m, native::m##Ptr, mt, GeodeClassIds::m>                  \
 
 Review comment:
   In the changes below this line, we went from "somethingPtr" to std::shared_ptr<"something">
var... So the ##Ptr was no longer required.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Protobuf protocol module will throw exceptions on some input
> ------------------------------------------------------------
>
>                 Key: GEODE-3149
>                 URL: https://issues.apache.org/jira/browse/GEODE-3149
>             Project: Geode
>          Issue Type: Bug
>          Components: client/server
>            Reporter: Brian Rowe
>             Fix For: 1.3.0
>
>
> The protobuf protocol handler needs to be able to handle any input on the incoming socket
without crashing.  
> Right now closing the socket will cause a crash as we try to process a message from the
empty stream (the bug here might be that the server connection shouldn't be trying to process
a message here, but the protocol deserialization still needs to have much better error handling).
> {code:java}
> severe 2017/06/28 13:50:55.565 PDT <ServerConnection on port 22514 Thread 0> tid=0x31]
Uncaught exception in thread Thread[ServerConnection on port 22514 Thread 0,5,ServerConnection
on port 22514]
> java.lang.NullPointerException
> 	at org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.processOneMessage(ProtobufStreamProcessor.java:67)
> 	at org.apache.geode.protocol.protobuf.ProtobufStreamProcessor.receiveMessage(ProtobufStreamProcessor.java:79)
> 	at org.apache.geode.internal.cache.tier.sockets.GenericProtocolServerConnection.doOneMessage(GenericProtocolServerConnection.java:68)
> 	at org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1155)
> 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> 	at org.apache.geode.internal.cache.tier.sockets.AcceptorImpl$1$1.run(AcceptorImpl.java:552)
> 	at java.lang.Thread.run(Thread.java:748)
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message