geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3136) Replace all public API time values with std::chrono types
Date Tue, 07 Nov 2017 17:18:00 GMT


ASF GitHub Bot commented on GEODE-3136:

pivotal-jbarrett commented on a change in pull request #144: GEODE-3136: Convert time values
to std::chrono::duration.

 File path: cppcache/src/ExpiryTaskManager.cpp
 @@ -58,7 +58,20 @@ long ExpiryTaskManager::scheduleExpiryTask(ACE_Event_Handler* handler,
   ACE_Time_Value expTimeValue(expTime);
   ACE_Time_Value intervalValue(interval);
-  LOGFINER("Scheduled expiration ... in %d seconds.", expTime);
+  return m_reactor->schedule_timer(handler, 0, expTimeValue, intervalValue);
+long ExpiryTaskManager::scheduleExpiryTask(
 Review comment:
   Its used internal still. There is another ticket for all internal time.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Replace all public API time values with std::chrono types
> ---------------------------------------------------------
>                 Key: GEODE-3136
>                 URL:
>             Project: Geode
>          Issue Type: Improvement
>          Components: native client
>            Reporter: Jacob S. Barrett
>            Assignee: Jacob S. Barrett
> Remove ambiguity of time values by using [{{std::chrono}}|]
types in the public API. 

This message was sent by Atlassian JIRA

View raw message