geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3007) Simplify support for custom GFSH commands
Date Fri, 17 Nov 2017 23:23:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257744#comment-16257744
] 

ASF subversion and git services commented on GEODE-3007:
--------------------------------------------------------

Commit 2b21e2bd6a3ba7fbcd9a2d8e93ae2aef852689ad in geode's branch refs/heads/develop from
[~jens.deppe]
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2b21e2b ]

Revert "GEODE-3007: Simplify support for custom GFSH commands (#1042)" (#1072)

This reverts commit 0e5dd6ba45519463147337c8265db15e8f1840fc.

> Simplify support for custom GFSH commands
> -----------------------------------------
>
>                 Key: GEODE-3007
>                 URL: https://issues.apache.org/jira/browse/GEODE-3007
>             Project: Geode
>          Issue Type: Improvement
>          Components: docs, gfsh
>            Reporter: Jared Stewart
>            Assignee: Jared Stewart
>
> Geode currently supports three ways to load GFSH commands: 
> 1. Scan the classpath for commands in "org.apache.geode.management.internal.cli.commands”
> 2. Scan the classpath for commands in a package specified by a user via the “user-command-packages”
system property. 
> 3. Scan the classpath for commands registered in files inside META-INF.services (e.g.
"geode-core/src/test/resources/META-INF/services/org.springframework.shell.core.CommandMarker”)

> After the improvements made by GEODE-2989, there is no reason to require a user to specify
the location of their custom commands via one of these mechanisms.  Instead, we should simply
scan the entire classpath for any classes implementing CommandMarker (regardless of whatever
packages they live in).  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message