geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3007) Simplify support for custom GFSH commands
Date Fri, 17 Nov 2017 21:03:00 GMT


ASF GitHub Bot commented on GEODE-3007:

jdeppe-pivotal opened a new pull request #1072: Revert "GEODE-3007: Simplify support for custom
GFSH commands (#1042)"
   This reverts commit 0e5dd6ba45519463147337c8265db15e8f1840fc.
   Thank you for submitting a contribution to Apache Geode.
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically
   - [ ] Is your initial contribution a single, squashed commit?
   - [ ] Does `gradlew build` run cleanly?
   - [ ] Have you written or updated unit tests to verify your changes?
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Simplify support for custom GFSH commands
> -----------------------------------------
>                 Key: GEODE-3007
>                 URL:
>             Project: Geode
>          Issue Type: Improvement
>          Components: docs, gfsh
>            Reporter: Jared Stewart
>            Assignee: Jared Stewart
> Geode currently supports three ways to load GFSH commands: 
> 1. Scan the classpath for commands in "”
> 2. Scan the classpath for commands in a package specified by a user via the “user-command-packages”
system property. 
> 3. Scan the classpath for commands registered in files inside (e.g.

> After the improvements made by GEODE-2989, there is no reason to require a user to specify
the location of their custom commands via one of these mechanisms.  Instead, we should simply
scan the entire classpath for any classes implementing CommandMarker (regardless of whatever
packages they live in).  

This message was sent by Atlassian JIRA

View raw message