geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3007) Simplify support for custom GFSH commands
Date Fri, 03 Nov 2017 17:02:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3007?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16237994#comment-16237994
] 

ASF GitHub Bot commented on GEODE-3007:
---------------------------------------

PurelyApplied commented on a change in pull request #1011: GEODE-3007: Simplify support for
custom GFSH commands
URL: https://github.com/apache/geode/pull/1011#discussion_r148837761
 
 

 ##########
 File path: geode-core/src/test/java/org/apache/geode/management/internal/cli/CommandManagerJUnitTest.java
 ##########
 @@ -45,46 +37,6 @@
 public class CommandManagerJUnitTest {
 
   private static final String COMMAND1_NAME = "command1";
 
 Review comment:
   I love seeing the purge, but should `COMMAND1_NAME` not also be on that chop block?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Simplify support for custom GFSH commands
> -----------------------------------------
>
>                 Key: GEODE-3007
>                 URL: https://issues.apache.org/jira/browse/GEODE-3007
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh
>            Reporter: Jared Stewart
>            Assignee: Jared Stewart
>            Priority: Major
>
> Geode currently supports three ways to load GFSH commands: 
> 1. Scan the classpath for commands in "org.apache.geode.management.internal.cli.commands”
> 2. Scan the classpath for commands in a package specified by a user via the “user-command-packages”
system property. 
> 3. Scan the classpath for commands registered in files inside META-INF.services (e.g.
"geode-core/src/test/resources/META-INF/services/org.springframework.shell.core.CommandMarker”)

> After the improvements made by GEODE-2989, there is no reason to require a user to specify
the location of their custom commands via one of these mechanisms.  Instead, we should simply
scan the entire classpath for any classes implementing CommandMarker (regardless of whatever
packages they live in).  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message