geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-2676) RegionMBean statistics wrong on partitioned regions
Date Thu, 16 Nov 2017 00:36:00 GMT


ASF GitHub Bot commented on GEODE-2676:

jinmeiliao commented on a change in pull request #1063: GEODE-2676: fix NPE with ShowMetricsCommand.

 File path: geode-core/src/test/java/org/apache/geode/management/internal/cli/commands/
 @@ -164,8 +158,16 @@ public void categoryOptionAbridgesOutput() throws Exception {
     List<String> expectedCategories = Arrays.asList("cluster", "cache", "");"Expecting categories: " + String.join(", ", expectedCategories));
-    gfsh.connectAndVerify(server.getEmbeddedLocatorPort(), PortType.locator);
         expectedCategories.toArray(new String[0]));
+  @Test
+  public void getRegionMetricsForPartitionedRegionWithStatistics() throws Exception {
+    String cmd = "create region --name=region2 --type=PARTITION --enable-statistics";
 Review comment:
   I think this is actually a valid comment. The "create region --type=PARTITION --enable-statistics"
should fail validation also. That's a usability issue we should have a ticket for.
   But that would not erase the need for the exception check in the RegionMBeanBridge. We
do not know for suer if other type of region would also have this kind of problem. 

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> RegionMBean statistics wrong on partitioned regions
> ---------------------------------------------------
>                 Key: GEODE-2676
>                 URL:
>             Project: Geode
>          Issue Type: Bug
>          Components: management
>            Reporter: Fred Krone
>            Priority: Minor
>              Labels: jmx
> RegionMBean attributes hitCount, hitRatio, missCount, lastAccessedTime, and lastModifiedTime
will always be 0 for an mbean that represents an partitioned region.
> The gettors for these methods may call getStatistics() which on a PR always throws UnsupportedOperationException.
So this exception might even get exposed to customers.
> The initialization of RegionMBeanBridge calls getStatisticsEnabled() which returns true
on a PartitionedRegion. This does have meaning on a PR but it does not mean that getStatistics()
is a supported operation. On a PR setting statistics-enabled causes each region-entry to also
keep track of its last access time.
> It is true that if getStatisticsEnabled() is false then you should not call getStatistics.
But the opposite is not true. Since we currently have regions that do not support getStatistics(),
the code in RegionMBeanBridge should catch UnsupportedOperationException and handle it. I
would suggest that the constructor be changed that initializes the "isStatisticsEnabled" field.
Instead of only calling getStatisticsEnabled() it should also call getStatistics(). Something
like this:
> {noformat}
>     {
>       boolean useGetStatistics = regAttrs.getStatisticsEnabled();
>       if (useGetStatistics) {
>         try {
>           region.getStatistics();
>         } catch (UnsupportedOperationException ex) {
>           useGetStatistics = false;
>         }
>       }
>       this.isStatisticsEnabled = useGetStatistics;
>     }
> {noformat}
> That way in a future release if PRs are changed to support getStatistics this code will
start calling it without having a direct dependency on the implementation of PartitionedRegion.
> is a request to support getStatistics
on PRs.

This message was sent by Atlassian JIRA

View raw message