Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Wed, 25 Oct 2017 14:50:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13109809.1508190660000.56804.1508943000202@Atlassian.JIRA>
In-Reply-To: <JIRA.13109809.1508190660000@Atlassian.JIRA>
References: <JIRA.13109809.1508190660000@Atlassian.JIRA> <JIRA.13109809.1508190660690@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-3843) gfsh shutdown error message
 suggests non-existent option
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 25 Oct 2017 14:50:05 -0000


    [ https://issues.apache.org/jira/browse/GEODE-3843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218815#comment-16218815 ] 

ASF GitHub Bot commented on GEODE-3843:
---------------------------------------

pdxrunner commented on a change in pull request #959: GEODE-3843: Fix gfsh shutdown error message
URL: https://github.com/apache/geode/pull/959#discussion_r146881976
 
 
 ##########
 File path: geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserParsingTest.java
 ##########
 @@ -362,4 +362,11 @@ public void testMultiLineCommand() throws Exception {
     assertThat(result.getParamValue("name")).isEqualTo("test");
     assertThat(result.getCommandName()).isEqualTo("start server");
   }
+
+  @Test
+  public void testShutdownWithOption() throws Exception {
+    String command = "shutdown --include-locators";
+    GfshParseResult result = parser.parse(command);
+    assertThat(result.getParamValue("include-locators")).isEqualTo("true");
 
 Review comment:
   Yes, that's the way I do my PRs: resolve any conflicts locally before pushing updates to the PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> gfsh shutdown error message suggests non-existent option
> --------------------------------------------------------
>
>                 Key: GEODE-3843
>                 URL: https://issues.apache.org/jira/browse/GEODE-3843
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>            Reporter: Dave Barnes
>            Assignee: Srikanth Manvi
>            Priority: Minor
>
> 1. Start gfsh.
> 2. Start a locator.
> 3. Issue the 'shutdown' command.
> gfsh prompts for 'do you really want to...', then issues an error message alerting you to the lack of data nodes. OK so far.
> This is followed by a line recommending that you use '--shutdown-locators' to stop your locator.
> Should be '--include-locators=true'.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)