Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 6AB84200D24 for ; Tue, 24 Oct 2017 22:48:07 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 692CF160BDB; Tue, 24 Oct 2017 20:48:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B27291609C8 for ; Tue, 24 Oct 2017 22:48:06 +0200 (CEST) Received: (qmail 75291 invoked by uid 500); 24 Oct 2017 20:48:05 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 75282 invoked by uid 99); 24 Oct 2017 20:48:05 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 24 Oct 2017 20:48:05 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id D274F1A06A1 for ; Tue, 24 Oct 2017 20:48:04 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.201 X-Spam-Level: X-Spam-Status: No, score=-99.201 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, URIBL_BLOCKED=0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id HqccIFMHSyuO for ; Tue, 24 Oct 2017 20:48:03 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 08BAD60E01 for ; Tue, 24 Oct 2017 20:48:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 1999CE0F3B for ; Tue, 24 Oct 2017 20:48:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 7CF64212FE for ; Tue, 24 Oct 2017 20:48:00 +0000 (UTC) Date: Tue, 24 Oct 2017 20:48:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: issues@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-3705) Refactor Authentication request to be processed as a "normal" protobuf message MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 24 Oct 2017 20:48:07 -0000 [ https://issues.apache.org/jira/browse/GEODE-3705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217667#comment-16217667 ] ASF GitHub Bot commented on GEODE-3705: --------------------------------------- kohlmu-pivotal commented on a change in pull request #967: GEODE-3705: Refactor Authentication request to be processed as a "normal" protobuf message URL: https://github.com/apache/geode/pull/967#discussion_r146687646 ########## File path: geode-protobuf/src/test/java/org/apache/geode/internal/protocol/protobuf/ProtobufShiroAuthenticatorJUnitTest.java ########## @@ -41,7 +42,7 @@ private static final String TEST_USERNAME = "user1"; private static final String TEST_PASSWORD = "hunter2"; private ByteArrayInputStream byteArrayInputStream; // initialized with an incoming request in - // setUp. + // setUp. Review comment: fixed ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org > Refactor Authentication request to be processed as a "normal" protobuf message > ------------------------------------------------------------------------------ > > Key: GEODE-3705 > URL: https://issues.apache.org/jira/browse/GEODE-3705 > Project: Geode > Issue Type: New Feature > Components: client/server > Reporter: Galen O'Sullivan > Assignee: Udo Kohlmeyer > > Refactor authentication and Authorization for the new protocol to process the AuthenticationRequest as a "normal" protobuf message. -- This message was sent by Atlassian JIRA (v6.4.14#64029)