Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 7094C200D2E for ; Tue, 31 Oct 2017 21:32:10 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 6F37C160BF9; Tue, 31 Oct 2017 20:32:10 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id B68031609E6 for ; Tue, 31 Oct 2017 21:32:09 +0100 (CET) Received: (qmail 69674 invoked by uid 500); 31 Oct 2017 20:32:08 -0000 Mailing-List: contact issues-help@geode.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@geode.apache.org Delivered-To: mailing list issues@geode.apache.org Received: (qmail 69665 invoked by uid 99); 31 Oct 2017 20:32:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 31 Oct 2017 20:32:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 3A6F2D2E47 for ; Tue, 31 Oct 2017 20:32:07 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id SYx7AX36RK_G for ; Tue, 31 Oct 2017 20:32:06 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 17EAD60F76 for ; Tue, 31 Oct 2017 20:32:06 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 245D0E0DFC for ; Tue, 31 Oct 2017 20:32:04 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id F3E8621317 for ; Tue, 31 Oct 2017 20:32:01 +0000 (UTC) Date: Tue, 31 Oct 2017 20:32:01 +0000 (UTC) From: "ASF subversion and git services (JIRA)" To: issues@geode.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (GEODE-3374) Refactor WAN tests to use test rules and remove WANCommandTestBase MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 31 Oct 2017 20:32:10 -0000 [ https://issues.apache.org/jira/browse/GEODE-3374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227472#comment-16227472 ] ASF subversion and git services commented on GEODE-3374: -------------------------------------------------------- Commit d0a2c3d1cd34e9abe13c9f4089e59cc09bfab500 in geode's branch refs/heads/develop from [~lhughesgodfrey] [ https://gitbox.apache.org/repos/asf?p=geode.git;h=d0a2c3d ] GEODE-3338 Refactor WAN command tests to use new Rules This commit includes refactoring the 13 test classes in WAN Command tests to use the new Test Rules vs. the deprecated CliCommandTestBase. In addition to GEODE-3338, please refer to GEODE-3362 through GEODE-3374 (one per test plus one to remove WANCommandTestBase) all of which are included as sub jiras for GEODE-1359. - Remove use of deprecated APIs in CliCommandTestBase - Remove WANCommandTestBase (all classes extended this class) - Refactored to use new rules - Removed FlakyTest specification for GEODE-1355, GEODE-1395, GEODE-1418 and GEODE-1448. > Refactor WAN tests to use test rules and remove WANCommandTestBase > ------------------------------------------------------------------ > > Key: GEODE-3374 > URL: https://issues.apache.org/jira/browse/GEODE-3374 > Project: Geode > Issue Type: Sub-task > Components: tests > Reporter: Emily Yeh > > {{WANCommandTestBase}} extends {{CliCommandTestBase}}, which is a deprecated class. Tests using this class should be refactored, after which this class should be removed. -- This message was sent by Atlassian JIRA (v6.4.14#64029)