Mailing-List: contact issues-help@geode.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@geode.apache.org
Date: Mon, 23 Oct 2017 20:53:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: issues@geode.apache.org
Message-ID: <JIRA.13005049.1473899809000.38349.1508791980481@Atlassian.JIRA>
In-Reply-To: <JIRA.13005049.1473899809000@Atlassian.JIRA>
References: <JIRA.13005049.1473899809000@Atlassian.JIRA> <JIRA.13005049.1473899809917@jira-lw-us.apache.org>
Subject: [jira] [Commented] (GEODE-1897) Users should be able to configure
 eviction through gfsh
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 23 Oct 2017 20:53:04 -0000


    [ https://issues.apache.org/jira/browse/GEODE-1897?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215818#comment-16215818 ] 

ASF GitHub Bot commented on GEODE-1897:
---------------------------------------

jdeppe-pivotal commented on a change in pull request #956: GEODE-1897: Initial refactor of CreateRegionCommand
URL: https://github.com/apache/geode/pull/956#discussion_r146390462
 
 
 ##########
 File path: geode-core/src/main/java/org/apache/geode/cache/AttributesFactory.java
 ##########
 @@ -1559,7 +1564,7 @@ public static void validateAttributes(RegionAttributes<?, ?> attrs) {
     Class<V> valueConstraint = null;
     int initialCapacity = 16;
     float loadFactor = 0.75f;
-    int concurrencyLevel = 16;
+    int concurrencyLevel = DEFAULT_CONCURRENCY_LEVEL;
 
 Review comment:
   I wanted to be able to reference this value outside of this class. I guess the other values aren't being used/referenced anywhere outside of this class.
   
   Also, the `AttributesFactory` class is deprecated, so making larger changes is less important I think.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Users should be able to configure eviction through gfsh
> -------------------------------------------------------
>
>                 Key: GEODE-1897
>                 URL: https://issues.apache.org/jira/browse/GEODE-1897
>             Project: Geode
>          Issue Type: Sub-task
>          Components: docs, gfsh
>            Reporter: Swapnil Bawaskar
>            Assignee: Jens Deppe
>
> While creating a region in gfsh, users should be able to configure eviction for that region.
> All three modes of eviction should be supported:
> 1. Eviction driven by the resource manager:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE --eviction-enabled
> {noformat}
> 2. eviction driven by entry count in the region:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE --eviction-entry-count=1000
> {noformat}
> 3. eviction driven by bytes used:
> {noformat}
> gfsh>create region --name=myRegion --type=REPLICATE --eviction-max-memory=100m
> {noformat}
> And also specify the eviction action as
> {noformat}
> --eviction-action=overflow-to-disk or
> --eviction-action=destroy
> {noformat}


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)