geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3903) Refactor current client protocol work to split the protocol from protobuf
Date Tue, 24 Oct 2017 23:47:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217892#comment-16217892
] 

ASF GitHub Bot commented on GEODE-3903:
---------------------------------------

WireBaron commented on a change in pull request #974: GEODE-3903: Splitting of client protocol
code from protobuf implementation
URL: https://github.com/apache/geode/pull/974#discussion_r146722585
 
 

 ##########
 File path: geode-protobuf/src/main/java/org/apache/geode/internal/protocol/protobuf/operations/RemoveRequestOperationHandler.java
 ##########
 @@ -35,14 +36,14 @@
 import static org.apache.geode.internal.protocol.ProtocolErrorCode.*;
 
 @Experimental
-public class RemoveRequestOperationHandler
-    implements OperationHandler<RegionAPI.RemoveRequest, RegionAPI.RemoveResponse>
{
+public class RemoveRequestOperationHandler implements
+    OperationHandler<RegionAPI.RemoveRequest, RegionAPI.RemoveResponse, ClientProtocol.ErrorResponse>
{
   private static final Logger logger = LogManager.getLogger();
 
   @Override
-  public Result<RegionAPI.RemoveResponse> process(SerializationService serializationService,
-      RegionAPI.RemoveRequest request, MessageExecutionContext messageExecutionContext)
-      throws InvalidExecutionContextException {
+  public Result<RegionAPI.RemoveResponse, ClientProtocol.ErrorResponse> process(
 
 Review comment:
   Probably not worth it just to simply out one template parameter, but we could define a:
   public ProtobufResult<SuccessResult> extends Result<SuccessResult, ClientProtocol.ErrorResponse>
   
   We could add a similar class extending OperationHandler as well.  This would be consistent
with how you added a ProtobufOperationContext.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Refactor current client protocol work to split the protocol from protobuf
> -------------------------------------------------------------------------
>
>                 Key: GEODE-3903
>                 URL: https://issues.apache.org/jira/browse/GEODE-3903
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Udo Kohlmeyer
>            Assignee: Udo Kohlmeyer
>
> Currently the protobuf protocol work is all in 1 module. Split the modules into 2 modules:
> * geode-client-protocol - specific to protocol only work
> * geode-protobuf - specific to the protobuf implementation for the client protocol



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message