geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3894) Create HandshakeRequest
Date Tue, 31 Oct 2017 21:31:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227644#comment-16227644
] 

ASF GitHub Bot commented on GEODE-3894:
---------------------------------------

WireBaron commented on a change in pull request #985: GEODE-3894: Create HandshakeRequest
URL: https://github.com/apache/geode/pull/985#discussion_r148132771
 
 

 ##########
 File path: geode-client-protocol/src/main/java/org/apache/geode/internal/protocol/state/ConnectionAuthenticatingStateProcessor.java
 ##########
 @@ -12,10 +12,18 @@
  * or implied. See the License for the specific language governing permissions and limitations
under
  * the License.
  */
-package org.apache.geode.internal.protocol.security;
+package org.apache.geode.internal.protocol.state;
 
-import org.apache.geode.security.ResourcePermission;
+import org.apache.geode.internal.protocol.state.exception.ConnectionStateException;
 
-public interface Authorizer {
-  boolean authorize(Object authenticatedToken, ResourcePermission permissionRequested);
+import java.util.Properties;
+
+public interface ConnectionAuthenticatingStateProcessor extends ConnectionStateProcessor
{
 
 Review comment:
   That is correct, I added those comments.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Create HandshakeRequest
> -----------------------
>
>                 Key: GEODE-3894
>                 URL: https://issues.apache.org/jira/browse/GEODE-3894
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Brian Baynes
>
> Make Handshake a HandshakeRequest that is contained in a Message the same way other requests
are handled.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message