geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3894) Create HandshakeRequest
Date Mon, 30 Oct 2017 16:30:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225262#comment-16225262
] 

ASF GitHub Bot commented on GEODE-3894:
---------------------------------------

kohlmu-pivotal commented on a change in pull request #985: GEODE-3894: Create HandshakeRequest
URL: https://github.com/apache/geode/pull/985#discussion_r147523593
 
 

 ##########
 File path: geode-client-protocol/src/main/java/org/apache/geode/internal/protocol/ConnectionShiroAuthorizingStateProcessor.java
 ##########
 @@ -0,0 +1,53 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more contributor license
+ * agreements. See the NOTICE file distributed with this work for additional information
regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache License, Version
2.0 (the
+ * "License"); you may not use this file except in compliance with the License. You may obtain
a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under
the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either
express
+ * or implied. See the License for the specific language governing permissions and limitations
under
+ * the License.
+ */
+package org.apache.geode.internal.protocol;
+
+import org.apache.geode.internal.security.SecurityService;
+import org.apache.geode.security.NotAuthorizedException;
+import org.apache.shiro.subject.Subject;
+import org.apache.shiro.util.ThreadState;
+
+public class ConnectionShiroAuthorizingStateProcessor implements ConnectionStateProcessor
{
+  SecurityService securityService;
 
 Review comment:
   I would prefer if these fields were `private final` rather than package private

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Create HandshakeRequest
> -----------------------
>
>                 Key: GEODE-3894
>                 URL: https://issues.apache.org/jira/browse/GEODE-3894
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Brian Baynes
>
> Make Handshake a HandshakeRequest that is contained in a Message the same way other requests
are handled.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message