geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (GEODE-3872) Consolidate GfshShellConnectionRule assertions
Date Wed, 25 Oct 2017 22:29:00 GMT


ASF GitHub Bot commented on GEODE-3872:

jaredjstewart commented on issue #978: GEODE-3872: Consolidate GfshShellConnectionRule Assertions
   Precheckin is still running

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Consolidate GfshShellConnectionRule assertions
> ----------------------------------------------
>                 Key: GEODE-3872
>                 URL:
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh, tests
>            Reporter: Jared Stewart
>            Assignee: Jared Stewart
> We have started to accumulate several flavors of _executeCommand_ methods on GfshShellConnectionRule
that implicitly make certain kinds of assertions.  (For example, assertions on the command
result status or on the output text.)  It would make the code more maintainable to separate
the various assertion methods into a separate class and to have a single executeCommand method.
> (See e.g.

This message was sent by Atlassian JIRA

View raw message