geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3872) Consolidate GfshShellConnectionRule assertions
Date Tue, 31 Oct 2017 17:21:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16227143#comment-16227143
] 

ASF GitHub Bot commented on GEODE-3872:
---------------------------------------

jaredjstewart opened a new pull request #997: GEODE-3872: Remove executeAndVerify method
URL: https://github.com/apache/geode/pull/997
 
 
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ x] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [x ] Has your PR been rebased against the latest commit within the target branch (typically
`develop`)?
   
   - [ x] Is your initial contribution a single, squashed commit?
   
   - [ x] Does `gradlew build` run cleanly?
   
   - [ x] Have you written or updated unit tests to verify your changes?
   
   - [ x] If adding new dependencies to the code, are these dependencies licensed in a way
that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, you check travis-ci for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Consolidate GfshShellConnectionRule assertions
> ----------------------------------------------
>
>                 Key: GEODE-3872
>                 URL: https://issues.apache.org/jira/browse/GEODE-3872
>             Project: Geode
>          Issue Type: Improvement
>          Components: gfsh, tests
>            Reporter: Jared Stewart
>            Assignee: Jared Stewart
>
> We have started to accumulate several flavors of _executeCommand_ methods on GfshShellConnectionRule
that implicitly make certain kinds of assertions.  (For example, assertions on the command
result status or on the output text.)  It would make the code more maintainable to separate
the various assertion methods into a separate class and to have a single executeCommand method.
> (See e.g. http://joel-costigliola.github.io/assertj/assertj-core-custom-assertions.html#custom-assertion-class)



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message