geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3843) gfsh shutdown error message suggests non-existent option
Date Wed, 25 Oct 2017 03:11:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3843?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16218036#comment-16218036
] 

ASF GitHub Bot commented on GEODE-3843:
---------------------------------------

srikanthmanvi commented on a change in pull request #959: GEODE-3843: Fix gfsh shutdown error
message
URL: https://github.com/apache/geode/pull/959#discussion_r146745537
 
 

 ##########
 File path: geode-core/src/test/java/org/apache/geode/management/internal/cli/GfshParserParsingTest.java
 ##########
 @@ -362,4 +362,11 @@ public void testMultiLineCommand() throws Exception {
     assertThat(result.getParamValue("name")).isEqualTo("test");
     assertThat(result.getCommandName()).isEqualTo("start server");
   }
+
+  @Test
+  public void testShutdownWithOption() throws Exception {
+    String command = "shutdown --include-locators";
+    GfshParseResult result = parser.parse(command);
+    assertThat(result.getParamValue("include-locators")).isEqualTo("true");
 
 Review comment:
   @jinmeiliao / reviewers,
   What is the best practice when there are newer commits in develop which would cause things
to break when the feature branch is merged into develop ? 
   
   Should I be merging develop into my feature branch, make additional changes if necessary
so that there are no breaking changes and only then submit a PR ? 
   Which would mean that I should merge develop into my feature branch and then make the change
as `assertThat(result.getParamValue("include-locators")).isEqualTo(true);` and then push the
commits.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> gfsh shutdown error message suggests non-existent option
> --------------------------------------------------------
>
>                 Key: GEODE-3843
>                 URL: https://issues.apache.org/jira/browse/GEODE-3843
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>            Reporter: Dave Barnes
>            Assignee: Srikanth Manvi
>            Priority: Minor
>
> 1. Start gfsh.
> 2. Start a locator.
> 3. Issue the 'shutdown' command.
> gfsh prompts for 'do you really want to...', then issues an error message alerting you
to the lack of data nodes. OK so far.
> This is followed by a line recommending that you use '--shutdown-locators' to stop your
locator.
> Should be '--include-locators=true'.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message