geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF subversion and git services (JIRA)" <>
Subject [jira] [Commented] (GEODE-3751) Refactor: ClientProtocolService, ClientStreamProcessor
Date Tue, 10 Oct 2017 18:18:00 GMT


ASF subversion and git services commented on GEODE-3751:

Commit 033757f5569126ad84ee4badf2c283481ec205b4 in geode's branch refs/heads/develop from
[;h=033757f ]

GEODE-3751: a single place for client protocol loading, logic.

* Load a single service, `ClientProtocolService`.
  - (well, authenticators are still separate).
* Move several interfaces to `geode-protobuf` from core.
* Client protocol state and statistics are now stored on the new
  `ClientProtocolPipeline` interface. This will allow us to keep
  connection logic for core separated from protocol logic.
* implement pipelines for Cache and Locator.
* some other small fixes and changes.

Signed-off-by: Galen O'Sullivan <>

This closes #873

Signed-off-by: Brian Rowe <>

> Refactor: ClientProtocolService, ClientStreamProcessor
> ------------------------------------------------------
>                 Key: GEODE-3751
>                 URL:
>             Project: Geode
>          Issue Type: Improvement
>          Components: client/server
>            Reporter: Galen O'Sullivan
>            Assignee: Galen O'Sullivan
> The protobuf protocol logic is currently partly in {{GenericProtocolServerConnection}},
but authentication shouldn't really be assumed if it's a generic connection. Refactoring to
a single service, with a pipeline that holds handshake/auth/message processing state, will
allow us to improve authentication/authorization as well as add a handshake with much less
> This is blocking GEODE-3705 and GEODE-3739.

This message was sent by Atlassian JIRA

View raw message