geode-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (GEODE-3299) Gfsh functions should acquire Cache from FunctionContext
Date Tue, 24 Oct 2017 23:01:00 GMT

    [ https://issues.apache.org/jira/browse/GEODE-3299?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16217847#comment-16217847
] 

ASF GitHub Bot commented on GEODE-3299:
---------------------------------------

jinmeiliao commented on a change in pull request #975: GEODE-3299: throw CacheClosedException
in FunctionContext.getCache()
URL: https://github.com/apache/geode/pull/975#discussion_r146715810
 
 

 ##########
 File path: geode-core/src/main/java/org/apache/geode/management/internal/cli/functions/ShowMissingDiskStoresFunction.java
 ##########
 @@ -65,23 +65,25 @@ public void execute(FunctionContext context) {
           }
         }
       }
+    } catch (CacheClosedException ignored) {
 
 Review comment:
   I don't think we want to do this specially for ShowMissingDiskStoresFunction alone. It's
ok for the function to throw this exception and have the function callers catch that. We will
need to adjust the test to assert getting this exception for a member without cache.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Gfsh functions should acquire Cache from FunctionContext
> --------------------------------------------------------
>
>                 Key: GEODE-3299
>                 URL: https://issues.apache.org/jira/browse/GEODE-3299
>             Project: Geode
>          Issue Type: Bug
>          Components: gfsh
>            Reporter: Kirk Lund
>            Assignee: Kenneth Howe
>             Fix For: 1.4.0
>
>
> Gfsh functions in geode-core org.apache.geode.management.internal.cli.functions currently
acquire a reference to the Cache in several ways including from a singleton in CacheFactory
which is prone to deadlocking. They should be modified to uniformly acquire the Cache from
FunctionContext instead.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message